T-X-D-D Support#1598
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds client-side handling for remote CoT delete tasking (t-x-d-d) in the web Atlas connection worker, enabling incoming task messages to remove (or immediately stale-out) referenced features in the local store.
Changes:
- Implement
t-x-d-dtask handling inAtlasConnectionto remove or stale linked CoT items, while blocking deletion of Mission-origin items. - Bump API dependencies (notably
@tak-ps/node-cot,sharp,c8) and updateapi/package-lock.jsonaccordingly. - Regenerate/update
api/derived-types.d.ts(openapi-typescript output), resulting in significant endpoint typing churn.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/web/src/workers/atlas-connection.ts | Adds t-x-d-d processing logic to remove or stale linked CoT features, with Mission-origin guard. |
| api/package.json | Updates API dependency versions (including @tak-ps/node-cot, sharp, c8) and package version. |
| api/package-lock.json | Lockfile refresh reflecting dependency upgrades and transitive changes. |
| api/derived-types.d.ts | Regenerated OpenAPI TypeScript definitions with substantial typing reordering/additions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
api/web/src/workers/atlas-connection.ts:249
- The t-x-d-d handler applies server-driven state changes using the normal client mutation paths, which can trigger outbound API writes. Specifically,
cot.update(...)may callsave()(PUT) for archived features, andatlas.db.remove(...)may issue a DELETE for archived features. For server-originated delete/stale tasking, these should be applied locally without re-saving/re-deleting over the network to avoid circular sync and permission/404 noise.
const forcedelete = task.properties.forcedelete === true;
for (const link of task.properties.links || []) {
if (!link.uid) continue;
const cot = await this.atlas.db.get(link.uid);
if (!cot) continue;
// Don't allow remote access to a Data Sync Mission (Priv. Escalation)
if (cot.origin.mode === OriginMode.MISSION) {
console.warn(`Ignoring t-x-d-d for ${link.uid} as it originates from a Mission`);
continue;
}
if (forcedelete) {
await this.atlas.db.remove(link.uid);
} else {
await cot.update({
properties: {
...cot.properties,
stale: new Date().toISOString()
}
});
}
takwerx
added a commit
to takwerx/infra-TAK
that referenced
this pull request
Jul 22, 2026
New marketplace entry (ping-style direct clone): https://github.com/clptak/cloudtak-plugin-search-containment @ d9c1a21 (scanned). ATAK Chokepoint-style SAR containment — ring offset from a mission shape/line/ manual point, numbered markers at trail-network crossings, posted to the active DataSync mission. Browser-only (no server routes, no new ports/auth paths); all network via CloudTAK's own std()/server helpers. /module-scan PASS — one LOW: no LICENSE file yet (author asked to add; ping is MIT). Universal dev switch applies automatically (repo currently has main only). cloudtak-replay-plugin (dfndr13) assessed and PARKED: targets pre-hub/api-split CloudTAK (api/routes/, api/lib/ — neither exists at our 13.50 pin; connection- pool.ts moved to api/stateful/lib/) and needs core-file patches the installer does not and should not apply. Revisit when upstream PR dfpc-coe/CloudTAK#1598 lands or the plugin ships a 13.45+ split-contract version. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
t-x-d-dmessages