Skip to content

Feature Sidebar => MenuTemplate - #1613

Merged
Nick (ingalls) merged 2 commits into
mainfrom
feat-template
Jul 26, 2026
Merged

Feature Sidebar => MenuTemplate#1613
Nick (ingalls) merged 2 commits into
mainfrom
feat-template

Conversation

@ingalls

@ingalls Nick (ingalls) commented Jul 26, 2026

Copy link
Copy Markdown
Member

Context

  • 🚀 Migrate the feature sidebar from a custom div to MenuTemplate for consistent mobile UI

Copilot AI review requested due to automatic review settings July 26, 2026 02:31
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../web/src/components/CloudTAK/Menu/MenuFeatView.vue 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ingalls Nick (ingalls) self-assigned this Jul 26, 2026
@ingalls Nick (ingalls) added the web-frontend Container for all web frontend issues label Jul 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Feature View menu component to use the shared MenuTemplate wrapper (aligning it with the rest of the CloudTAK menu UI patterns), and also updates the npm lockfile with a set of dependency upgrades.

Changes:

  • Migrate MenuFeatView.vue from a bespoke header/body layout to MenuTemplate, moving actions into the #buttons slot and using the none state when no feature is selected.
  • Update package-lock.json with a broad set of dependency version bumps (AWS SDK, eslint/tooling, and related transitive deps).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package-lock.json Updates a wide set of locked dependency versions (AWS SDK, eslint/tooling, etc.).
api/web/src/components/CloudTAK/Menu/MenuFeatView.vue Refactors the Feature View sidebar to render inside MenuTemplate and restructures the header buttons/body slots.
Comments suppressed due to low confidence (1)

api/web/src/components/CloudTAK/Menu/MenuFeatView.vue:32

  • The Raw/Default view toggle is still shown when feature is falsy, but the body content is gated behind v-if='feature', so the buttons do nothing (and the header suggests functionality that isn't available). Since MenuTemplate shows buttons even in the none state, these toggles should also be guarded by feature.
            <TablerIconButton
                v-if='mode === "default"'
                title='Raw View'
                @click='mode = "raw"'
            >

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/web/src/components/CloudTAK/Menu/MenuFeatView.vue
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 26, 2026 02:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

api/web/src/components/CloudTAK/Menu/MenuFeatView.vue:33

  • The Raw/Default view toggle renders even when feature is falsy, which exposes buttons that only toggle internal state but cannot change the displayed content (the menu is in the none state). Gate these buttons on feature (and consider making the conditions explicit to avoid showing the Default View button for unexpected mode values).
            <TablerIconButton
                v-if='mode === "default"'
                title='Raw View'
                @click='mode = "raw"'
            >

Comment thread api/web/src/components/CloudTAK/Menu/MenuFeatView.vue
@ingalls
Nick (ingalls) merged commit eebb36a into main Jul 26, 2026
15 of 16 checks passed
@ingalls
Nick (ingalls) deleted the feat-template branch July 26, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-frontend Container for all web frontend issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants