Feature Sidebar => MenuTemplate - #1613
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Feature View menu component to use the shared MenuTemplate wrapper (aligning it with the rest of the CloudTAK menu UI patterns), and also updates the npm lockfile with a set of dependency upgrades.
Changes:
- Migrate
MenuFeatView.vuefrom a bespoke header/body layout toMenuTemplate, moving actions into the#buttonsslot and using thenonestate when no feature is selected. - Update
package-lock.jsonwith a broad set of dependency version bumps (AWS SDK, eslint/tooling, and related transitive deps).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package-lock.json | Updates a wide set of locked dependency versions (AWS SDK, eslint/tooling, etc.). |
| api/web/src/components/CloudTAK/Menu/MenuFeatView.vue | Refactors the Feature View sidebar to render inside MenuTemplate and restructures the header buttons/body slots. |
Comments suppressed due to low confidence (1)
api/web/src/components/CloudTAK/Menu/MenuFeatView.vue:32
- The Raw/Default view toggle is still shown when
featureis falsy, but the body content is gated behindv-if='feature', so the buttons do nothing (and the header suggests functionality that isn't available). SinceMenuTemplateshows buttons even in thenonestate, these toggles should also be guarded byfeature.
<TablerIconButton
v-if='mode === "default"'
title='Raw View'
@click='mode = "raw"'
>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
api/web/src/components/CloudTAK/Menu/MenuFeatView.vue:33
- The Raw/Default view toggle renders even when
featureis falsy, which exposes buttons that only toggle internal state but cannot change the displayed content (the menu is in thenonestate). Gate these buttons onfeature(and consider making the conditions explicit to avoid showing the Default View button for unexpectedmodevalues).
<TablerIconButton
v-if='mode === "default"'
title='Raw View'
@click='mode = "raw"'
>
Context