-
Notifications
You must be signed in to change notification settings - Fork 220
Relax bounds #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax bounds #2602
Conversation
LGTM; Thank you @TeofilC ! |
Could we please get a corresponding Hackage revision? |
Oops! Sorry about that I believe these should all be published as matching revisions to Hackage now |
Thanks! |
you're welcome! |
It's an easy mistake to make (we need better tooling!), but it appears that tests weren't actually run with these new versions. At the very least, $ cabal build lib:dhall --constraint=time==1.14 # requires removing other entries from `cabal.project`
Build profile: -w ghc-9.10.1 -O1
In order, the following will be built (use -v for more details):
- dhall-1.42.2 (lib) (first run)
Preprocessing library for dhall-1.42.2...
Building library for dhall-1.42.2...
[32 of 77] Compiling Dhall.Syntax.Instances.Lift ( src/Dhall/Syntax/Instances/Lift.hs, /home/gthomas/code/dhall-haskell/dist-newstyle/build/x86_64-linux/ghc-9.10.1/dhall-1.42.2/build/Dhall/Syntax/Instances/Lift.o, /home/gthomas/code/dhall-haskell/dist-newstyle/build/x86_64-linux/ghc-9.10.1/dhall-1.42.2/build/Dhall/Syntax/Instances/Lift.dyn_o ) [Data.Time package changed]
src/Dhall/Syntax/Instances/Lift.hs:24:1: error: [GHC-59692]
Duplicate instance declarations:
instance Lift Time.Day
-- Defined at src/Dhall/Syntax/Instances/Lift.hs:24:1
instance [safe] Lift Time.Day
-- Defined in ‘time-1.14:Data.Time.Calendar.Days’
|
24 | deriving instance Lift Time.Day
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: [Cabal-7125]
Failed to build dhall-1.42.2. This case is fixed by #2647. We ought to test the others and publish Hackage revisions re-tightening the bounds where appropriate. |
It's confusing that if you do git blame, you see this PR as updating to support time-1.14. But dhall on Hackage does still not accept time-1.14 since the upper bound was explicitly downgraded in a revision: https://hackage.haskell.org/package/dhall-1.42.2/revisions/ Probably would be most reliable to make a new release. Especially since the time bump done in #2649 needs a CPP change, which can't be done with revisions. |
@ysangkok: I uploaded a new release of dhall. Hopefully that should fix the remaining issues, but let me know if I missed something |
@Gabriella439 : Thank you. In addition, dhall-{bash,json,yaml} could easily be fixed with new revisions. I have just verified that their Hackage uploads all work on GHC 9.12 if I pass |
This relaxes most bounds as indicated by cabal outdated.
I've checked and all the tests pass. This allows building the library with GHC 9.10.
The only thing I've left behind is lsp as it seems like there's some breaking changes there and there's an existing PR for that.
In order to build with GHC-9.10, you will also need the following allow-newers added to cabal.project: