Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use microlens package family instead of lens-family-core #2642

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

mmhat
Copy link
Collaborator

@mmhat mmhat commented Feb 13, 2025

The switch is motivated by

  • the desire to get rid of the profunctors dependency.
  • I think we should could slim down Dhall.Optics (and deprecate it eventually).

A related comment of mine is here: #1102 (comment)

Fixes #998

@mmhat
Copy link
Collaborator Author

mmhat commented Feb 13, 2025

Depends on stevenfontanella/microlens#185

All optics in that module are now available in the latest microlens
package.

Also got rid of profunctors dependency.
@mmhat mmhat marked this pull request as ready for review February 20, 2025 14:58
@mmhat mmhat enabled auto-merge (squash) February 20, 2025 15:07
@mmhat mmhat disabled auto-merge February 20, 2025 15:29
@mmhat mmhat enabled auto-merge (squash) February 20, 2025 15:46
@mmhat mmhat merged commit 7982475 into dhall-lang:main Feb 20, 2025
9 checks passed
@mmhat mmhat deleted the microlens branch February 20, 2025 16:06
@TristanCacqueray
Copy link
Collaborator

Well done @mmhat , that's great, one less lens library to think about!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventual fate of the Dhall.Optics module
3 participants