Open
Conversation
houndci-bot
reviewed
Jul 31, 2018
| console.log(`Reset blockchain to snapshot with ID: ${originSnapshot}`); | ||
| } | ||
|
|
||
| console.log("\n\n* Test Teardown Complete *\n"); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
|
|
||
| if (originSnapshotString && originSnapshot >= 0) { | ||
| await web3Utils.revertToSnapshot(originSnapshot); | ||
| console.log(`Reset blockchain to snapshot with ID: ${originSnapshot}`); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
| const web3Utils = new Web3Utils(web3); | ||
|
|
||
| module.exports = async () => { | ||
| console.log("\n\n* Test Teardown *\n"); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
|
|
||
| console.log(`Saved origin snapshot with ID: ${originSnapshot}`); | ||
|
|
||
| console.log("\n\n* Test Setup Complete *\n"); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
|
|
||
| process.env.originSnapshot = originSnapshot.toString(); | ||
|
|
||
| console.log(`Saved origin snapshot with ID: ${originSnapshot}`); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
| const web3Utils = new Web3Utils(web3); | ||
|
|
||
| module.exports = async () => { | ||
| console.log("\n\n* Test Setup *\n"); |
There was a problem hiding this comment.
Calls to 'console.log' are not allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This outlines a way to do origin snapshotting, so that we can reset to an origin snapshot during test setup without needing to save snapshots, etc.
One thing I'm uncertain about is whether the script .ts files get transpiled on difference machines - because this needs to happen in order to work. Will look to circle to find out.