Skip to content

Feature optimize merge function - #236

Merged
ochedru merged 3 commits into
dhatim:masterfrom
meiMingle:feature-optimize_merge_function
Dec 20, 2022
Merged

Feature optimize merge function#236
ochedru merged 3 commits into
dhatim:masterfrom
meiMingle:feature-optimize_merge_function

Conversation

@meiMingle

Copy link
Copy Markdown
Collaborator

Optimize the method of judging whether a cell is in any merged range. According to the test case based on #185, it can save about half of the time. Close #185 .

Comment thread fastexcel-writer/src/main/java/org/dhatim/fastexcel/Worksheet.java Outdated
@ochedru

ochedru commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

Nice job, thank you for your PR!

@ochedru
ochedru merged commit ee950a4 into dhatim:master Dec 20, 2022
@meiMingle
meiMingle deleted the feature-optimize_merge_function branch December 21, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Worksheet.isCellInMergedRanges make write slow.

2 participants