Skip to content

Commit

Permalink
chore: always use "continue" text in choose-dashboard-type-modal button
Browse files Browse the repository at this point in the history
  • Loading branch information
HendrikThePendric committed Feb 10, 2025
1 parent bb5641e commit 0f2b16b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
11 changes: 4 additions & 7 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2025-02-10T11:01:21.083Z\n"
"PO-Revision-Date: 2025-02-10T11:01:21.084Z\n"
"POT-Creation-Date: 2025-02-10T11:08:21.621Z\n"
"PO-Revision-Date: 2025-02-10T11:08:21.622Z\n"

msgid "Untitled dashboard"
msgstr "Untitled dashboard"
Expand Down Expand Up @@ -93,11 +93,8 @@ msgstr "External: Data from another source"
msgid "Embed a dashboard from a third-party source, like Superset."
msgstr "Embed a dashboard from a third-party source, like Superset."

msgid "Create dashboard"
msgstr "Create dashboard"

msgid "Configure source"
msgstr "Configure source"
msgid "Continue"
msgstr "Continue"

msgid "Not available for embedded dashboards"
msgstr "Not available for embedded dashboards"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,16 @@ export const ChooseDashboardTypeModal = ({
const handleDashboardTypeChange = useCallback(({ value }) => {
setSelectedType(value)
}, [])
const isInternal = selectedType === TYPE_INTERNAL

return (
<Modal onClose={onCancel}>
<form onSubmit={isInternal ? onSelectInternal : onSelectSuperset}>
<form
onSubmit={
selectedType === TYPE_INTERNAL
? onSelectInternal
: onSelectSuperset
}
>
<ModalTitle>
{i18n.t('New dashboard: choose type', {
nsSeparator: '###',
Expand Down Expand Up @@ -78,9 +83,7 @@ export const ChooseDashboardTypeModal = ({
<ModalActions>
<div className={styles.buttonStrip}>
<Button primary type="submit">
{isInternal
? i18n.t('Create dashboard')
: i18n.t('Configure source')}
{i18n.t('Continue')}
</Button>
<Button secondary onClick={onCancel}>
{i18n.t('Cancel')}
Expand Down

0 comments on commit 0f2b16b

Please sign in to comment.