Skip to content

Commit

Permalink
fix: handle special characters in delete dialog and no dashboards fou…
Browse files Browse the repository at this point in the history
…nd message (#3209)

Part of implementation for Implements DHIS2-6647
  • Loading branch information
jenniferarnesen authored Feb 7, 2025
1 parent 7708452 commit 40d7f58
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
11 changes: 7 additions & 4 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2023-05-10T12:25:45.620Z\n"
"PO-Revision-Date: 2023-05-10T12:25:45.620Z\n"
"POT-Creation-Date: 2025-02-07T11:22:46.614Z\n"
"PO-Revision-Date: 2025-02-07T11:22:46.615Z\n"

msgid "Untitled dashboard"
msgstr "Untitled dashboard"

msgid "No dashboards found for \"{{- filterText}}\""
msgstr "No dashboards found for \"{{- filterText}}\""

msgid "Cannot create a dashboard while offline"
msgstr "Cannot create a dashboard while offline"

Expand Down Expand Up @@ -228,11 +231,11 @@ msgid "Delete dashboard"
msgstr "Delete dashboard"

msgid ""
"Deleting dashboard \"{{ dashboardName }}\" will remove it for all users. "
"Deleting dashboard \"{{- dashboardName }}\" will remove it for all users. "
"This action cannot be undone. Are you sure you want to permanently delete "
"this dashboard?"
msgstr ""
"Deleting dashboard \"{{ dashboardName }}\" will remove it for all users. "
"Deleting dashboard \"{{- dashboardName }}\" will remove it for all users. "
"This action cannot be undone. Are you sure you want to permanently delete "
"this dashboard?"

Expand Down
2 changes: 1 addition & 1 deletion src/components/DashboardsBar/Content.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const Content = ({
if (filteredList.length === 0) {
return (
<span className={classes.noDashboardsMessage}>
{i18n.t('No dashboards found for "{{filterText}}"', {
{i18n.t('No dashboards found for "{{- filterText}}"', {
filterText,
})}
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/edit/ActionsBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ const EditBar = ({ dashboard, ...props }) => {
<ConfirmActionDialog
title={i18n.t('Delete dashboard')}
message={i18n.t(
'Deleting dashboard "{{ dashboardName }}" will remove it for all users. This action cannot be undone. Are you sure you want to permanently delete this dashboard?',
'Deleting dashboard "{{- dashboardName }}" will remove it for all users. This action cannot be undone. Are you sure you want to permanently delete this dashboard?',
{ dashboardName: dashboard.name }
)}
cancelLabel={i18n.t('Cancel')}
Expand Down

0 comments on commit 40d7f58

Please sign in to comment.