fix: show user's search text in the No dashboards found message [v39] #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dashboards-app
|
||||||||||||||||||||||||||||||||||
| Project |
dashboards-app
|
| Branch Review |
fix/show-filter-text-v39
|
| Run status |
|
| Run duration | 04m 58s |
| Commit |
|
| Committer | Jen Jones Arnesen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
57
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/view/item_context_menu.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| Item context menu > Open the interpretations panel |
Screenshots
Video
|
|
|
🚀 Deployed on https://pr-3208.dashboard.netlify.dhis2.org |
HendrikThePendric
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-6647
Include the search text in the "No dashboards found" message to better inform the user.