chore: adjust e2e dev workflow so that it works #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
added
the
e2e dev
|
🚀 Deployed on https://pr-3231.dashboard.netlify.dhis2.org |
|
HendrikThePendric
changed the title
jenniferarnesen
approved these changes
Mar 3, 2025
HendrikThePendric
added
the
e2e record
dashboards-app
|
||||||||||||||||||||||||||||
| Project |
dashboards-app
|
| Branch Review |
chore/check-e2e-dev-workflow
|
| Run status |
|
| Run duration | 03m 00s |
| Commit |
|
| Committer | Hendrik de Graaf |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
14
|
| View all changes introduced in this branch ↗︎ | |
HendrikThePendric
removed
the
e2e record
|
🎉 This PR is included in version 101.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
SHOULD_RECORDin an env var to make the conditional logic less complex*[*] Note that the env var is a string, so you see
== 'true'. Also note that I could not do the same forSHOULD_RUNbecause env variables are not available in job-conditions (ifproperties of a job block).I have checked and the parallelisation seems to be working fine.
I will also check if the
e2e recordlabel affects this new workflow as intended.