fix: support bundled LL app (DHIS2-17400) #3238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since api/apps does not return bundled apps that don't have a manually installed version, a hardcoded path is needed for pointing the iframe to the correct plugin. This is the same approach we already use for DV and Maps.
|
|
🚀 Deployed on https://pr-3238.dashboard.netlify.dhis2.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17400
Key features
Description
Since
api/appsdoes not return bundled apps that don't have a manually installed version, a hardcoded path is needed for pointing the iframe to the correct plugin. This is the same approach we already use for DV and Maps.This change shouldn't affect the existing way of loading the LL plugin as currently the
pluginLaunchUrlfromapi/appsis always used if LL app is installed.The manually installed versions always take precedence, the bundled apps hardcoded paths are used as fallback.
TODO