Skip to content

fix(command palette): remove dual focus functionality #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Jan 31, 2025

Fixes BETA-222


Description

  • This PR removes the dual focus caused by highlighting items in the command palette either by:

    • use of the arrow keys, or
    • hovering over them.
  • Focus on an item can now only be done through arrow key navigation.


Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

@d-rita d-rita requested a review from a team as a code owner January 31, 2025 20:33
Copy link

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1657--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 31, 2025 20:36 Inactive
@d-rita d-rita changed the title fix: remove dual focus functionality fix(command palette): remove dual focus functionality Jan 31, 2025
@d-rita d-rita requested a review from a team February 3, 2025 07:46
@d-rita d-rita mentioned this pull request Feb 5, 2025
3 tasks
@d-rita
Copy link
Contributor Author

d-rita commented Feb 14, 2025

Closing this PR since its implementation is fixed and updated in PR #1661

@d-rita d-rita closed this Feb 14, 2025
@d-rita d-rita deleted the BETA-222/remove-dual-focus branch February 24, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants