fix: app redirects on command palette launch #1658
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-18943
Description
This PR separates the keydown logic specific to the command palette component from that attached to the document.
Previous Behaviour:
Enter
key on the apps menu icon, an app would open immediately.Enter
key logic triggering the selection of the first highlighted item, hence redirecting to the app.Fixed Behaviour:
Ctrl/Meta
+/
) used to open the command palette is attached to the document since it can be triggered anywhere within the app.Enter
key on the apps menu icon opens the command palette without a problemChecklist
Screenshots
Before
before.mov
After
after.mov