feat: mobile-config — emit mobile_doctype + derive meta-refresh signal [review-only]#36
Open
nadge-sachin wants to merge 1 commit into
Open
feat: mobile-config — emit mobile_doctype + derive meta-refresh signal [review-only]#36nadge-sachin wants to merge 1 commit into
nadge-sachin wants to merge 1 commit into
Conversation
…d_at Mobile meta changes (hidden/new/relabelled fields) now propagate without a cache clear: - emit mobile_doctype (the key the SDK reads) alongside mobile_workspace_item - derive doctype_meta_modifed_at as MAX(modified) across the form + its child doctypes + Property Setters + Custom Fields (reuses rf_mis meta_override.compute_meta_modified, with a safe fallback)
abhijitnairDhwani
left a comment
abhijitnairDhwani
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the commit (79a99d0) — correct: emits mobile_doctype (the key the SDK actually reads) alongside mobile_workspace_item, and derives doctype_meta_modifed_at via rf_mis compute_meta_modified with a try/except fallback (single source of truth; tech debt noted re: the inverted generic->site dependency). NOT approving-to-merge: per our policy mobile_control stays on its feature branch (feat/rf-mis-auth) and is not merged to develop — this PR is a review surface only, so ignore the develop conflict. The change is good to keep on the feature branch and deploy with the rf_mis side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The mobile_control half of the mobile meta-refresh fix (companion: rf_mis PR dhwani-ris/frappe_rf_mis#59, + a project-end SDK change). Server field changes (hide / new / relabel) weren't reaching the app without a cache clear.
This PR (
api/helpers/mobile_config.py, single commit79a99d0)mobile_doctypein the config payload — the key the SDK actually reads (mobile_form_name.dart). The server only emittedmobile_workspace_item, so the signal never registered.mobile_workspace_itemis kept for the server-side consumers (permissions.py).doctype_meta_modifed_at=MAX(modified)across the form + its child doctypes + Property Setters + Custom Fields, by reusingrf_mis.rf_mis.api.meta_override.compute_meta_modified(single source of truth with the meta stamp). Safe try/except fallback to the stored value.Tech debt (flagged per review)
mobile_controlnow imports a helper fromrf_mis— an inverted dependency (generic app → site app). Acceptable for now sincemobile_controlis feature-branch-only and ships alongside rf_mis; long-term the helper should move to a generic layer or be duplicated.Status
mobile_controlis feature-branch-only and not merged until project end. Base isdeveloppurely to give a clean single-commit diff; do not merge to develop. Retarget if you'd prefer a different base.📄 Full write-up + proof: https://claude.ai/code/artifact/bf2acb21-313f-4565-bb29-8424134fbda4