Skip to content

fix(anthropic): remove top_p parameter for Claude 4.5 models#521

Merged
di-sukharev merged 3 commits into
di-sukharev:masterfrom
muni-corn:claude-fix-top-p
Feb 21, 2026
Merged

fix(anthropic): remove top_p parameter for Claude 4.5 models#521
di-sukharev merged 3 commits into
di-sukharev:masterfrom
muni-corn:claude-fix-top-p

Conversation

@muni-corn

Copy link
Copy Markdown
Contributor

removes the top_p parameter if the configured model string contains -4-5. this fixes #520 , where opencommit will fail because Anthropic does not support both temperature and top_p for their 4.5 models.

@di-sukharev

Copy link
Copy Markdown
Owner

thank you @muni-corn

Comment thread src/engine/anthropic.ts Outdated
@muni-corn muni-corn requested a review from di-sukharev October 22, 2025 14:29
@muni-corn

Copy link
Copy Markdown
Contributor Author

hey @di-sukharev , have you had a chance to check this out again? 😁

@devacc00

Copy link
Copy Markdown

@di-sukharev ping

1 similar comment
@sKawashima

Copy link
Copy Markdown

@di-sukharev ping

@Heyian

Heyian commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

@di-sukharev Would it be possible to merge this please? @muni-corn has made the requested changes and this issue forces us to either work on a fork or disable auto-updating since we can't use oco with anthropic's models without this PR...
Thanks!

@Thevetat

Copy link
Copy Markdown

Anything here? Just had a fail from haiku 3.5 deprecation so now cant use this.

@di-sukharev di-sukharev merged commit de5d5cb into di-sukharev:master Feb 21, 2026
@di-sukharev

Copy link
Copy Markdown
Owner

@Thevetat thanks, merged, will release a new version tmr

@di-sukharev

Copy link
Copy Markdown
Owner

@Thevetat @muni-corn @devacc00 @sKawashima done

@sKawashima

Copy link
Copy Markdown

thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: temperature and top_p cannot both be specified for Claude Haiku 4.5 and Sonnet 4.5

6 participants