Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Panel - Resistances #7714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kphoenix137
Copy link
Collaborator

Depends on: #7713

Changes resistances to utilize narrow labels, since horizontal spacing isn't an issue with any amount of resistances. Additionally, we then have enough space to change "Resist Element" to "Element Resistance"

image

@kphoenix137 kphoenix137 changed the title Charpanel resists Character Panel - Resistances Feb 5, 2025
@qndel
Copy link
Member

qndel commented Feb 6, 2025

what's up with that damage btw?

@glebm
Copy link
Collaborator

glebm commented Feb 6, 2025

It'd be nice if the mana box were vertically aligned with the light res box, I think for that the resistances need to move 1px up

@julealgon
Copy link
Contributor

Nice change.

The only suggestion/comment (other than spacing mentioned by @glebm ) is that it would be cool if there was a neater way to avoid the "Resistance" repetition by having some sort of "header" called "Resistances", and then have only the element names for each value, like "Magic", "Fire" and "Lightning" instead of "Magic Resistance", "Fire Resistance" and "Lightning Resistance", but that might require a larger overhaul of the UI due to spacing and consistency reasons.

@kphoenix137
Copy link
Collaborator Author

It'd be nice if the mana box were vertically aligned with the light res box, I think for that the resistances need to move 1px up

It brings me great pain that it's not aligned, and I didn't notice until you mentioned it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants