Add JupyterHub singleuser support and VS Code proxy#56
Conversation
Install jupyterhub (for hub communication) and jupyter-vscode-proxy (for browser-based VS Code via JupyterHub UI). Add default CMD for jupyterhub-singleuser which KubeSpawner can override as needed.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jlee733
left a comment
jlee733
left a comment
There was a problem hiding this comment.
Please see question regarding line 30 of the dockerfile
|
|
||
| # Install the local package in editable mode within the environment | ||
| RUN /usr/local/bin/micromamba run -n mdx2-dev pip install -e . | ||
| RUN /usr/local/bin/micromamba run -n mdx2-dev pip install --no-cache-dir jupyterhub jupyter-vscode-proxy |
There was a problem hiding this comment.
Was this added as an alternative way to access Jupyter notebooks or as an alternative to how we currently access Jupyter notebooks (launch Jupyter Lab server and then paste the URL into VS Code or in your local browser)?
There was a problem hiding this comment.
It's additive. Just gives you a VS Code option in the JupyterLab launcher. Everything else works the same as before.
There was a problem hiding this comment.
Especially handy for upcoming workspace orchestration stuff
2 participants
Summary
jupyterhubandjupyter-vscode-proxypackages to the Docker imagejupyterhub-singleuserTest plan
docker build .succeedsdocker run -p 8888:8888starts JupyterLab with VS Code button