-
Notifications
You must be signed in to change notification settings - Fork 4
Add flexible Diffuse params runs #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xraymemory
wants to merge
4
commits into
main
Choose a base branch
from
add-diffuse-yaml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ef691f9
Add diffuse.yaml for Diffuse platform integration
xraymemory d854002
Fix CLI flag names to match run_grid_search.py
xraymemory a39bb0d
Fix CLI command in header comment: trigger → start
xraymemory 09feea5
Add flexible Diffuse params runs
xraymemory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # diffuse.yaml -- the contract between Sampleworks and Diffuse. | ||
| # | ||
| # Apply with: diffuse apply | ||
| # Run with: diffuse run sampleworks --params params.json --output-dir /data/results/run-001 | ||
| # | ||
| # Idempotent -- safe to apply repeatedly. | ||
|
|
||
| version: 1 | ||
|
|
||
| type: sampleworks | ||
| name: Sampleworks | ||
| description: > | ||
| Generic Sampleworks experiment runner. Diffuse accepts a flexible params.json | ||
| blob, stores it for traceability, materializes it inside the pod, and lets | ||
| Sampleworks own validation and model-specific execution. | ||
|
|
||
| profiles: | ||
| - slug: sampleworks | ||
| name: Sampleworks | ||
| container: | ||
| image: diffuseproject/sampleworks | ||
| tag: latest | ||
| gpus: | ||
| min: 2 | ||
| entrypoint: null | ||
| input_schema: | ||
| inputs: | ||
| - key: params_json | ||
| type: json | ||
| required: true | ||
| description: Arbitrary Sampleworks-owned params.json object. | ||
| - key: output_dir | ||
| type: text | ||
| required: true | ||
| default: /data/results | ||
| description: Container output directory, usually under /data/results. | ||
| run_config_defaults: | ||
| shared_memory_size: "16Gi" | ||
| image_pull_policy: IfNotPresent | ||
| poll_max_retries: 720 | ||
| params_file: | ||
| param_key: params_json | ||
| path: /diffuse/input/params.json | ||
| volumes: | ||
| - name: data-input | ||
| hostPath: /data/sampleworks-exp/input | ||
| mountPath: /data/input | ||
| readOnly: true | ||
| - name: data-results | ||
| hostPath: /data/sampleworks-exp/grid_search_results | ||
| mountPath: /data/results | ||
| - name: msa-cache | ||
| hostPath: /data/sampleworks-exp/msa_cache | ||
| mountPath: /root/.sampleworks/msa | ||
| args_template: | ||
| base_command: [--params, /diffuse/input/params.json] | ||
| flag_args: | ||
| output_dir: --output-dir | ||
| boolean_args: {} | ||
| static_args: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the inline annotations off these continued shell lines.
In
bash,\only continues the command when it is the last character on the line. With the trailing comments here, this example is not copy/pasteable as written.🔧 Suggested doc fix
📝 Committable suggestion
🤖 Prompt for AI Agents