bugfix for SVA cover #1068
Merged
bugfix for SVA cover #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
cover_sequence1
branch
2 times, most recently
from
b0f94a4 to
29b70bf
Compare
tautschnig
approved these changes
Apr 22, 2025
| @@ -119,7 +119,7 @@ exprt normalize_property(exprt expr) | |||
| { | |||
| // top-level only | |||
| if(expr.id() == ID_sva_cover) | |||
| expr = G_exprt{not_exprt{to_sva_cover_expr(expr).op()}}; | |||
| expr = sva_always_exprt{not_exprt{to_sva_cover_expr(expr).op()}}; | |||
There was a problem hiding this comment.
I think we were missing the corresponding comment in normalize_property.h -- would you mind adding that one?
This changes the implicit 'always' used for SVA cover properties from LTL G to SVA always. This avoids a mixture of LTL and SVA, which is not supported by the BMC backend.
kroening
force-pushed
the
cover_sequence1
branch
from
29b70bf to
b871008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the implicit 'always' used for SVA cover properties from LTL G to SVA
always. This avoids a mixture of LTL and SVA, which is not supported by the BMC backend.