SMV: set type #1175
Open
SMV: set type #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smv-set
branch
7 times, most recently
from
f8f63ac to
43eb3fd
Compare
tautschnig
reviewed
Jun 30, 2025
src/smvlang/expr2smv.cpp
Outdated
Comment on lines
659
to
660
| else if(src.id() == ID_smv_set) | ||
| return convert_nondet_choice(src); |
There was a problem hiding this comment.
This looks strange. Is this just a re-use of a function that wasn't meant to be used that way?
Comment on lines
-794
to
-795
| else if(src.id() == ID_constraint_select_one) | ||
| return convert_nondet_choice(src); |
This fixes typechecking for set literals, assignments from set literals to variables of the element type, and typechecking for the "in" set membership operator.
tautschnig
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes typechecking for set literals, assignments from set literals to variables of the element type, and typechecking for the
inset membership operator.