Verilog: cleanup downwards type propagation #1292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
verilog-downwards-prop
branch
from
efc46fe to
ef2522f
Compare
|
Should the failing regression test cause the test to be changed or is this a bug being introduced? |
I'll change the test. I think it's better not to try to optimise during type checking, even if it's just folding a constant. |
|
I'll do the semantic change as a separate PR. |
This cleans up verilog_typecheck_exprt::downwards_type_progatation to handle all the cases in 1800-2017 11.8.2.
kroening
force-pushed
the
verilog-downwards-prop
branch
from
ef2522f to
9b7f39d
Compare
|
Restored previous semantics, which prevents the test failure |
tautschnig
reviewed
Oct 3, 2025
Comment on lines
+235
to
+254
| static exprt zero_extend(const exprt &expr, const typet &type) | ||
| { | ||
| auto old_width = expr.type().id() == ID_bool ? 1 | ||
| : expr.type().id() == ID_integer | ||
| ? 32 | ||
| : to_bitvector_type(expr.type()).get_width(); | ||
|
|
||
| // first make unsigned | ||
| typet tmp_type; | ||
|
|
||
| if(type.id() == ID_unsignedbv) | ||
| tmp_type = unsignedbv_typet{old_width}; | ||
| else if(type.id() == ID_verilog_unsignedbv) | ||
| tmp_type = verilog_unsignedbv_typet{old_width}; | ||
| else | ||
| PRECONDITION(false); | ||
|
|
||
| return typecast_exprt::conditional_cast( | ||
| typecast_exprt::conditional_cast(expr, tmp_type), type); | ||
| } |
There was a problem hiding this comment.
Wouldn't use of zero_extend_exprt make this unnecessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up
verilog_typecheck_exprt::downwards_type_progatationto handle all the cases in 1800-2017 11.8.2.