Fix executed proposals when Safe tx fails#320
Merged
Conversation
Validate Safe receipts (ExecutionSuccess/ExecutionFailure) before marking action proposals executed, persist tx hashes on failures, and add a backfill script.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionSuccess/ExecutionFailurelogs (and receipt status).status=executedproposals and reclassify failures.What Changed
packages/web/src/server/routers/action-proposals-router.ts:markExecutednow validates Safe execution before updating status; supports AA flows by resolvinguserOpHash -> txHashvia EntryPointUserOperationEvent(Base).packages/web/src/app/(authenticated)/dashboard/(bank)/components/dashboard/unified-activity.tsx: retriesmarkExecutedwhile verification is pending/unverified and surfaces failures.packages/web/scripts/backfill-action-proposals-executed.ts: script to re-verify and reclassify previously executed proposals.How To Test
ExecutionSuccess.pnpm --filter @zero-finance/web tsx scripts/backfill-action-proposals-executed.ts --dry-run --limit 500--workspace-id <uuid>Notes
pnpm --filter @zero-finance/web test -- --run