fix: skip non-directory entries in listScopeIds - #18
Open
yulong-ge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
listScopeIds()treats every entry returned byreaddirSyncas a scope ID. On macOS, Finder writes.DS_Storefiles into the scopes root; any plain file that happens to share the directory would also be mis-identified. This causes downstream operations (job loading, storage init) to fail or produce unexpected results.Changes
listScopeIds(): UsereaddirSync(root, { withFileTypes: true })and filter byentry.isDirectory()instead of probing each name withexistsSync(scopeDir(name)).ensureScopeStorage(): Add a guard — if the resolved scope path exists but is not a directory, return early instead of trying to create sub-dirs inside a file.listScopeIdswith an optionalrootparameter so it can be unit-tested against temp directories..DS_Store, stray files, mixed entries, no-throw guarantee.