feat(mcp): add pause/resume controls#1571
Open
shizhigu wants to merge 4 commits intodifferent-ai:devfrom
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@shizhigu is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
nice one!! just made a PR for the same yesterday #1562 |
Contributor
Author
9f20464 to
1c77ba8
Compare
1c77ba8 to
5f9e5fb
Compare
5f9e5fb to
4f4af86
Compare
fe409bc to
64b871f
Compare
Collaborator
|
quite some conflicts here because we made some changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1562 added the MCP enable/disable route. This keeps that user-facing flow, but covers the cases that matter once MCP config is shared: inherited global apps, no-op toggles, approval races, and desktop fallback. Users can pause an app without deleting its URL, headers, OAuth setup, or local config.
What changed
PATCH /workspace/:id/mcp/:namewith{ enabled: boolean }and keep the mergedPOST /enabledroute on the same server path.mcp.<name>.enabledflag for pause/resume.Test plan
pnpm --filter openwork-server exec bun test src/mcp.remote-connect.e2e.test.ts src/mcp-routes.e2e.test.tsbun test apps/app/src/app/mcp.test.ts apps/app/tests/connections-store-mcp-toggle.test.ts apps/app/tests/settings-route-permissions.test.tspnpm --filter openwork-server typecheckpnpm --filter openwork-server build:binpnpm --filter @openwork/app typecheckpnpm --filter @openwork/app buildgit diff --checkEvidence
Enabled app with the Pause action:
Paused app with the Resume action:
Notes