Fix Electron alpha updater manifest lookup#1626
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoUpdater.channeltoalphafor the generic alpha feed.alpha-macos-latestwhile allowing Electron to request the existinglatest-mac.ymlmanifest.Root Cause
autoUpdater.channel = \"alpha\"makes electron-updater requestalpha-mac.yml. The alpha release publisheslatest-mac.yml, so update checks 404 even though the release assets exist.Verification
node --check apps/desktop/electron/updater.mjspnpm install --frozen-lockfile --prefer-offlinepnpm --filter @openwork/app typecheckhttps://github.com/different-ai/openwork/releases/download/alpha-macos-latest/latest-mac.ymlreturns the alpha manifest.alpha-macos-latestrelease containslatest-mac.ymlviagh release view.