I18n: Remove unnessecary useTranslate() React hook#1646
Merged
benjaminshafii merged 1 commit intodifferent-ai:devfrom May 4, 2026
Merged
I18n: Remove unnessecary useTranslate() React hook#1646benjaminshafii merged 1 commit intodifferent-ai:devfrom
benjaminshafii merged 1 commit intodifferent-ai:devfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@johnnyshields is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
benjaminshafii
force-pushed
the
i18n-remove-react-hook
branch
from
8412ec8 to
d401e32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #1639
This PR removes more piece of I18n cruft from the codebase: a React hook that calls I18n.t() directly, and oddly wraps it in two different but similar functions.
A React hook like this could be useful in the future if there were some dynamic logic to re-render when the user's selected language changes, but as it stands none of that is implemented today, so it's better to just remove/replace the hook cleanly with I18n.t(), and if you ever need such logic in the future you can cleanly reimplement a new hook with hopefully just one wrapper function!