Fixing Linux Issues#8
Merged
Merged
Conversation
C17 has been chosen because C23 has the `bool` as a reserved keyword, but bool has been defined in shared/types.h causing errors.
Fixing the shebang to be #!/ instead of #/! Multiplatform support for qemu networking as vmnet-bridged is a MacOS only feature
Owner
|
It might be worth putting the asm defines into types.h, it's included by pretty much every other file |
Contributor
Author
|
I'll move that asm fix now and there is a fix for the vmnet issue |
Owner
|
I'll add the change to the raspberry pi branch as well, since it'll be overwritten eventually anyway. Thanks for the fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a few issues while compiling and running on Linux that I have fixed. The bool keyword is reserved as of C23, so I have adding in the CFLAGS to use C17 (the standard before C23), vmnet-bridged is a MacOS only feature and needs to be changed for Linux, and the asm keyword isn't defined by some compilers, but asm is there is a check for that in the files that use the asm keyword