Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/db migration student tbl #2

Merged
merged 12 commits into from
Jan 7, 2025

Conversation

colinpeng-datascience
Copy link
Member

Description

Feature: student table and students page

Added CICD to deploy onto supabase on merge/PR. Added student table in supabase with migration. Pulled changes and integrated with frontend.

Still need to add secrets SUPABASE_PROJECT_REF and SUPABASE_DB_PWD for the CICD to work.

What type of PR is this? (check all applicable)

  • Refactor
  • [ V] Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…etailsTable component in MainCard of students/index. Pagination and sort states included but not being used as api is not developed yet.
…to null in api/cePlanService and api/ceSessionService
Copy link

github-actions bot commented Dec 16, 2024

Visit the preview URL for this PR (updated for commit ae91d16):

https://culturous-exchange--pr2-feat-db-migration-st-7v77dv5j.web.app

(expires Tue, 24 Dec 2024 23:40:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: adcc28caa9b7c1d3b1670a080fce5f1f054a3a92

@jnakaso
Copy link
Contributor

jnakaso commented Dec 17, 2024

Most businesses use a singular noun for the name of tables by convention. For example, student instead of students of student_table. I reads clearer when you right SQL. For example,

SELECT name FROM student WHERE name = 'Ann'

Copy link
Contributor

@jnakaso jnakaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can address separating the creation of example data into another PR.

availabilities JSONB DEFAULT '[]' -- Storing availabilities as a JSON array
);

-- Insert the first student
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid including example records in the migrations dataset. Separate example data creation into another file that is not part of migration.

@colinpeng-datascience colinpeng-datascience merged commit 7a24cf4 into dev Jan 7, 2025
3 checks passed
@colinpeng-datascience colinpeng-datascience deleted the feat/db-migration-student-tbl branch January 7, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants