-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/db migration student tbl #2
Conversation
…etailsTable component in MainCard of students/index. Pagination and sort states included but not being used as api is not developed yet.
…to null in api/cePlanService and api/ceSessionService
…b-migration-student-tbl
Visit the preview URL for this PR (updated for commit ae91d16): https://culturous-exchange--pr2-feat-db-migration-st-7v77dv5j.web.app (expires Tue, 24 Dec 2024 23:40:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: adcc28caa9b7c1d3b1670a080fce5f1f054a3a92 |
Most businesses use a singular noun for the name of tables by convention. For example,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We can address separating the creation of example data into another PR.
availabilities JSONB DEFAULT '[]' -- Storing availabilities as a JSON array | ||
); | ||
|
||
-- Insert the first student |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid including example records in the migrations dataset. Separate example data creation into another file that is not part of migration.
Description
Feature: student table and students page
Added CICD to deploy onto supabase on merge/PR. Added student table in supabase with migration. Pulled changes and integrated with frontend.
Still need to add secrets SUPABASE_PROJECT_REF and SUPABASE_DB_PWD for the CICD to work.
What type of PR is this? (check all applicable)