4103: Open feedback via URL query#4168
Open
bahaaTuffaha wants to merge 8 commits into
Open
Conversation
steffenkleinle
requested changes
Jun 10, 2026
steffenkleinle
left a comment
Member
There was a problem hiding this comment.
Really really nice refactoring, gerat work! I love it! I think we can make a few things even simpler/more consistent, but otherwise this looks great already!
Tested on firefox, works as expected!
bahaaTuffaha
commented
Jun 10, 2026
bahaaTuffaha
commented
Jun 10, 2026
5b2a0cf to
ee8e4e6
Compare
steffenkleinle
requested changes
Jun 11, 2026
24f1cae to
7caed3c
Compare
…ction at useQueryParamVisibility
04fad3b to
3b22f30
Compare
steffenkleinle
approved these changes
Jun 13, 2026
steffenkleinle
left a comment
Member
There was a problem hiding this comment.
Nice work! Not tested again :)
lunars97
requested changes
Jun 18, 2026
lunars97
left a comment
Contributor
There was a problem hiding this comment.
Looks almost perfect to me 😻 , except for one question below.
lunars97
approved these changes
Jun 18, 2026
lunars97
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for cleaning up and simplifying everything. Not tested again, tested before in Chrome as well as for Malte and Aschaffenburg 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
We currently open the feedback via a local state parameter. While this works good for our feedback buttons, it is not possible to open the feedback from other routes (e.g. a link in a popup) without including the whole feedback component in the tree again, which is complicated, error prone and leads to duplication.
Proposed Changes
FEEDBACK_QUERY_KEYand new param totoQueryParams.useQueryParamVisibilityand adjusted the open function to accept an optional parametervalue.FeedbackContainerfromFeedbackToolbarIteminto RegionContentLayout.tsx to behave like chat so it can be open form any where.FeedbackContainerto wrap the feedback with dialog instead and removed all of the props because we will depend on the queries to get the value for the feedback and the search query.FeedbackContainerfromFeedbackToolbarItem.tsxandRegionContentMenu.tsx.useSearchFeedback.tsand path to extract slug.Side Effects
Testing
Resolved Issues
Fixes: #4103