Skip to content

Be more strict and prevent incomplete patterns #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Be more strict and prevent incomplete patterns #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bfac60
More changes to cabal files
amitaibu Feb 21, 2025
41aa90a
Add to ghci
amitaibu Feb 21, 2025
580e614
Change applicationGhciConfig
amitaibu Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ghci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
:set -XDeepSubsumption
:set -XOverloadedRecordDot
:set -Werror=missing-fields
:set -Werror=incomplete-patterns
:set -fwarn-incomplete-patterns
:set -Wno-ambiguous-fields
:set -O0
Expand Down
1 change: 1 addition & 0 deletions ihp-hsx/ihp-hsx.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ library
-Winaccessible-code
-Wmissed-specialisations
-Wall-missed-specialisations
-Werror=incomplete-patterns
-fspecialise-aggressively
-funfolding-use-threshold=120
-fdicts-strict
Expand Down
4 changes: 4 additions & 0 deletions ihp-ide/ihp-ide.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ common shared-properties
-Wmissed-specialisations
-Wall-missed-specialisations
-Wno-ambiguous-fields
-Werror=incomplete-patterns
else
ghc-options:
-fstatic-argument-transformation
Expand All @@ -134,6 +135,7 @@ common shared-properties
-Wall-missed-specialisations
-fspecialise-aggressively
-Wno-ambiguous-fields
-Werror=incomplete-patterns

library
import: shared-properties
Expand Down Expand Up @@ -235,6 +237,7 @@ executable RunDevServer
-threaded
+RTS -A512m -n4m -H512m -G3 -qg -N -RTS
-Wno-ambiguous-fields
-Werror=incomplete-patterns
else
ghc-options:
-fconstraint-solver-iterations=100
Expand All @@ -257,6 +260,7 @@ executable RunDevServer
-with-rtsopts=--nonmoving-gc
+RTS -A256m -n4m -H512m -G3 -qg -N -RTS
-Wno-ambiguous-fields
-Werror=incomplete-patterns

executable new-application
import: shared-properties
Expand Down
4 changes: 2 additions & 2 deletions ihp-ide/lib/IHP/applicationGhciConfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
:set -XDeepSubsumption
:set -XOverloadedRecordDot
:set -Werror=missing-fields
:set -fwarn-incomplete-patterns
:set -ferror-incomplete-patterns
:set -package ghc
:set -fno-warn-ambiguous-fields
:set -fno-warn-ambiguous-fields
:l Main.hs
1 change: 1 addition & 0 deletions ihp-openai/ihp-openai.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ library
-Wmissing-fields
-Winaccessible-code
-Wmissed-specialisations
-Werror=incomplete-patterns
-fexpose-all-unfoldings
hs-source-dirs: .
exposed-modules:
Expand Down
2 changes: 2 additions & 0 deletions ihp.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ common shared-properties
-Wmissed-specialisations
-Wall-missed-specialisations
-Wno-ambiguous-fields
-Werror=incomplete-patterns
else
ghc-options:
-fstatic-argument-transformation
Expand All @@ -165,6 +166,7 @@ common shared-properties
-Wmissed-specialisations
-Wall-missed-specialisations
-Wno-ambiguous-fields
-Werror=incomplete-patterns

library
import: shared-properties
Expand Down
Loading