Fix back button after form submit

[amitaibu]

fixes #2063

• Remove initBack which seems no longer used (?)
• Modernize initDisableButtonsOnSubmit to use a better way to prevent double binding

@unhammer could you try this PR locally to confirm it works for you?

[unhammer]

AFAICT this change has no effect on the issue.

From how I read the code, initBack only does something if you've manually added a <button class="js-back">. I can't find this js-back class documented anywhere (git log --stat -S js-back only shows changes to helpers.js) and I can find no open source usages on github https://github.com/search?q=js-back+hsx+language%3Ahaskell&type=code so it seems ripe for deprecation, but I also don't see how it can be related to my issue.

I tried adding some logging to see whether initDisableButtonsOnSubmit was being run twice, it doesn't seem like it was being run twice before either. In any case, the issue remains on my end.

Did the issue disappear in your testing with this patch?

[amitaibu]

Sorry, I thought I had fixed it, but re-checking it didn't. Let me try again.

[amitaibu]

(My assumption is that after the form redirect, the new page isn't registered on the history)

[amitaibu]

With Bug

with-bug-Peek.2025-05-05.19-27.mp4

With PR

Peek.2025-05-05.19-26.mp4

[unhammer]

OMG this seems to actually work :-D

I have to test it more extensively, but it seems like this does the trick.

I wonder what the reason was for replaceState instead of pushState there in the first place – could there be some difference between submitting and staying in the same url (except query parameters?) vs submitting and redirecting to a new url?

[amitaibu]

I wonder what the reason was for replaceState instead of pushState there in the first place

Hopefully @mpscholten will remember 😄

[amitaibu]

This is the fix for the back button