Fixed the max volume mount default from 7 to 15#646
Open
jasondcamp wants to merge 1 commit into
Open
Conversation
jasondcamp
force-pushed
the
jasondcamp_max_volume_limit
branch
from
799ffdd to
8348a67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue with the maximum volume mounts hitting the limit of 7. According to https://docs.digitalocean.com/products/volumes/details/limits/ the limit is raised to 15 now.
There was a const that defined the value, as well as a command line flag, i consolidated it down to a single source of truth in the const, and also updated the case to match other const patterns.
I also fixed a typo in some tests that said test_enabed, changed to test_enabled.