Skip to content

fix exclude_if_none to do what it should #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix exclude_if_none to do what it should #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jsonobject/base_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class JsonProperty(object):
type_config = None

def __init__(self, default=Ellipsis, name=None, choices=None,
required=False, exclude_if_none=False, validators=None,
required=False, exclude_if_none=True, validators=None,
verbose_name=None, type_config=None):
validators = validators or ()
self.name = name
Expand Down Expand Up @@ -93,7 +93,7 @@ def doc_type(self):
return self

def exclude(self, value):
return self.exclude_if_none and not value
return self.exclude_if_none and value is None

def empty(self, value):
return value is None
Expand Down