refactor: use # for private methods to reduce the minified file size #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the bundle size using # for the private properties instead of the private keyword when the code is minified.
The results of
esbuild ./rapier.js --bundle --minify --target=esnext --format=esm --outfile=out.js:which is about 1.04% smaller. If you can find more private methods/property, It can be even smaller.
The principle is explained here.
The PR is tested on my own app.