Skip to content

Conversation

@dimitri
Copy link
Owner

@dimitri dimitri commented Feb 5, 2024

No description provided.

@dimitri dimitri added the documentation Improvements or additions to documentation label Feb 5, 2024
@dimitri dimitri added this to the v0.16 milestone Feb 5, 2024
@dimitri dimitri requested a review from hanefi February 5, 2024 14:49
@dimitri dimitri self-assigned this Feb 5, 2024
Copy link
Contributor

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to our docs.

.. code-block:: sql
:linenos:
with citus_tables AS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with citus_tables AS
WITH citus_tables AS

ELSE 'distributed'
END AS citus_table_type,
coalesce(column_to_column_name(logicalrelid, partkey), '<none>')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure if it looks better if we capitalize coalesce call here.

Feel free to ignore this suggestion.

Suggested change
coalesce(column_to_column_name(logicalrelid, partkey), '<none>')
COALESCE(column_to_column_name(logicalrelid, partkey), '<none>')

Co-authored-by: Hanefi Onaldi <[email protected]>
@dimitri dimitri removed this from the v0.16 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants