feat(ETH): gas limit override test #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves memory usage a bit by doing preallocation when possible
This commit adds missed apply_event for events discovered while taker was offline, like the maker spent or watcher refunded the taker payment.
…ir (GLEECBTC#2115) `sign_and_send_transaction_with_keypair` now uses the address provided from the caller instead of having `my_address` inside it.
Testnet bitcoin currently has high fees which causes some tests to fail due to not enough balance. Since failing tests don't send actual tbtc, this commit sets a fixed fee to fix these tests.
This commit implements pubkey-only mode for the Tendermint protocol, which means we can use any external wallet for wallet and swap operations on Tendermint. Additionally, ibc_withdraw RPC is removed and withdraw is refactored for Tendermint to support IBC transfers by automatically finding IBC channels whenever possible.
This avoids concurrent reading/writing by enabling .tmp file for swap and order files. This fix should not create a problem for two mm2 instances running on the same node as both would use different directories for their data, derived from different listening IP-addresses.
UTXO P2PK balance is shown as part of the P2PKH/Legacy address balance, it can be also spent in withdraws and swaps.
This commit does the following: * Adds eth EIP1559 priority fee estimator * Adds tx priority fee support for withdraw and swaps * Improve gas limit for swap txns
…CBTC#2125) Test test_taker_completes_swap_after_taker_payment_spent_while_offline sometimes fails, apparently due to too early taker stop, so it does not have time to send p2p message with taker payment data to the maker. This fix improves the test log wait condition to ensure the p2p message is sent and only then taker stops.
Addresses bunch of potential database problems by improving the validation function.
Fixes a regression (check mm2_tests::tendermint_tests::test_tendermint_withdraw_hd test) which started with pubkey-only activation implementation.
* handle base64 encoded transaction values Signed-off-by: onur-ozkan <work@onurozkan.dev> * add coverage for history parsing Signed-off-by: onur-ozkan <work@onurozkan.dev> * increase test coverage Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit tries to get global with type safety and explicit type conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.