chore: scrub internal network identifiers - #61
Merged
Conversation
jmagar
force-pushed
the
chore/scrub-internal-identifiers-20260805
branch
from
August 5, 2026 05:12
a487531 to
9d23f4c
Compare
Collaborator
Author
|
Addressed the review findings:
Also merged a duplicate/divergent copy of the original commit from Verified: |
Replaces internal homelab network identifiers that leaked into this
public repository's docs, CI config, and test fixtures.
Replacement mapping:
- LAN IP 10.1.0.2 -> 192.0.2.2 (RFC5737 doc range)
- Tailscale IP 100.80.57.104 -> 198.51.100.1
- Tailscale IP 100.120.242.29 -> 198.51.100.2
- Host name dookie -> devhost
- Host name tootie -> nashost
No occurrences of the tailnet domain (manatee-triceratops), squirts,
shart, steamy/steamyy, vivobook, steamdeck, willynet, mothership, or
any *.tootie.tv hostname were found on origin/main, so nothing needed
changing for those.
Renames were applied consistently across docs, CI config
(.github/actionlint.yaml self-hosted-runner labels are declared but
unused by any workflow's runs-on:, so this is a label-name-only
change), and Rust source/test fixtures (including the
`ProjectDirs::from("tv", "tootie", "ytdl-rmcp")` per-user cache/config
directory identity in src/bootstrap.rs, now "nashost" - this changes
the on-disk cache directory name for future installs/updates of the
published package, which is expected as part of scrubbing this
identifier).
Sanity check: `cargo check -q` and `cargo test -q` both pass clean
(183 tests, 0 failed) after the rename.
- Revert the ProjectDirs XDG qualifier back to tv/tootie/ytdl-rmcp:
that string is the app's on-disk cache/state/config identity, not
a hostname reference, and renaming it silently orphans every
existing user's data directory on upgrade.
- Fix dookie->devhost mis-mapping in README.md and its
packages/ytdl-rmcp/README.md mirror ("On dookie/local shells" line),
matching the mapping used consistently elsewhere in the diff.
- Run cargo fmt --all to fix the wrap-width failure in
src/setup_tests.rs introduced by the identifier substitution.
jmagar
force-pushed
the
chore/scrub-internal-identifiers-20260805
branch
from
August 25, 2026 12:53
64b1fa9 to
5a941f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces internal network identifiers in tracked files with neutral documentation placeholders: private LAN addresses -> 192.0.2.0/24 values, overlay-network addresses -> 198.51.100.0/24 values, the internal tailnet domain -> example.ts.net, internal service domains -> *.example.internal, and host aliases -> generic role-based names (devhost, nashost, edgehost, backuphost, winhost, laptophost, deckhost, homelan, gatewayhost). No functional changes intended; see the diff for the full set of edits.