test: use neutral fixture identifiers in remaining test data - #337
Merged
Conversation
Completes the identifier scrub started in #325/#333 by replacing the last real-username fixture literals with the neutral 'devuser' placeholder: - soma-auth sqlite session fixture email - synapse-application process-row observability fixture - synapse import syslog/auth log samples (already on 'devhost') Excludes xtask scaffolding defaults (github_owner) and historical CHANGELOG commit URLs, which are real values rather than fixtures. Test fixture literals only; no behavior change.
jmagar
enabled auto-merge (squash)
August 6, 2026 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the internal-identifier scrub started in #325 and #333. Replaces the last real-username fixture literals with the neutral
devuserplaceholder — 5 lines across 3 files:crates/shared/auth/src/sqlite_tests.rs— session fixture emailcrates/synapse/application/src/runtime_test_observability.rs— process-row fixture usercrates/synapse/import/src/scout_service/logs_tests.rs— syslog/auth log samples (these already useddevhost, so the username now matches)Deliberately excluded
Two categories of
jmagarhit remain in the tree and are not fixtures:xtask/src/{cargo_generate,cargo_generate_post,scaffold}.rs—github_ownerdefaults and slug-rewrite pairs. These are real scaffolding behavior, not placeholders; renaming them would change what generated servers point at.crates/synapse/import/CHANGELOG.md— historical release links to real commits and issues.Scope
Test fixture literals only — no behavior change. Diff is exactly symmetric (5 insertions, 5 deletions).
Verification
crates/synapse/importis a separate cargo workspace, so it is tested independently.After this and #326 land, no
dookie/jmagarfixture literal remains anywhere in the repo's Rust sources.