feat(signal): add native voice note support for Signal platform#1
Open
directorboint-arch wants to merge 1 commit intomainfrom
Open
feat(signal): add native voice note support for Signal platform#1directorboint-arch wants to merge 1 commit intomainfrom
directorboint-arch wants to merge 1 commit intomainfrom
Conversation
- tools/tts_tool.py: Include 'signal' in want_opus check so TTS tools generate Opus (.ogg) audio for Signal just like Telegram, enabling proper voice message format. - gateway/platforms/signal.py: Rewrite send_voice() to pass voiceNote=true to signal-cli's JSON-RPC API so Signal renders audio as inline voice messages with waveform playback instead of plain file attachments. Includes proper size validation and typing indicators. - website/docs/user-guide/messaging/signal.md: Update docs to reflect that send_voice now delivers inline voice notes rather than attachments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native voice note support for the Signal platform, enabling inline voice message playback instead of plain file attachments.
Changes
1. TTS output format for Signal
Added
signalto thewant_opusplatform check intools/tts_tool.pyso TTS tools generate Opus (.ogg) audio for Signal, matching Telegram behavior.2. Signal voice note delivery
Rewrote
send_voice()ingateway/platforms/signal.pyto passvoiceNote=trueto signal-cli's JSON-RPC API. This makes Signal render audio as inline voice messages with waveform playback instead of plain file attachments.3. Documentation
Updated
website/docs/user-guide/messaging/signal.mdto reflect thatsend_voicenow delivers inline voice notes.Motivation
Signal users were receiving TTS audio as file attachments instead of voice messages. This brings Signal parity with Telegram and WhatsApp for voice clip delivery.