-
Notifications
You must be signed in to change notification settings - Fork 33
Major Upgrade - Latest Nuxt Packages #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! Almost all of my comments are just type error/linting stuff. Besides the APi navigation comment. Wonder if we should add typechecking, linting, and formatting to the docs and setup GitHub workflows to validate it and run tests?
|
||
async function copyPage() { | ||
try { | ||
const value = (props.page?.rawbody ?? '').replace(/\\n/g, '\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When copying the markdown of a page, it does not resolve partials...wondering if it should? For instance, copying start has this line in it :partial{content="license"}
instead of the license partial!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's correct - it was a tradeoff.
Should be improved but even the Nuxt team doesn't seem to have a great way to handle this yet.
One idea was to just convert the final rendered HTML back into markdown. But again didn't want scope to keep creeping on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! Almost all of my comments are just type error/linting stuff. Besides the APi navigation comment. Wonder if we should add typechecking, linting, and formatting to the docs and setup GitHub workflows to validate it and run tests?
Co-authored-by: Connor Winston <[email protected]>
We should probably do this yes. But maybe not in this one eh? |
Lots of changes in this one. Biggest one is upgrading Nuxt packages significantly improves dev performance.
Overview Video
Notable Changes
Add support for copy raw page to markdown (for LLMs)
Newsletter Callout at bottom of page
Tweaks to API Reference
Still Left To Do
/tutorials
routes (shows all tutorials, should only show tutorial sections and tags (technologies)