First version including a docker image#4
Merged
Conversation
Owner
|
Happy to include it in the Contributed Recipes. I'll push a version so it's published. |
Contributor
Author
|
Perfect, thank you. I will push the recipe to the Jupyter Docker Stacks soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @dirkcgrunwald,
Great job, it's a very interesting integration you've started here.
I would like to reference it as a Contributed Recipes of Jupyter Docker Stacks.
So I've drafted an example of integration directly in this repo in order to be able to build and integrate it at the same location.
I think it could be interesting to go further and publish the python package.
Please let me know if you are interested. If so I could bring some help.
Note: This PR integrates the fix made in PR #3 because it does not work without this fix.
Best.