Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where circle angle property resets to 0 after first element when applying warp to multiple elements #1

Merged
merged 1 commit into from
Feb 10, 2013

Conversation

ericfreese
Copy link
Contributor

Instead of overwriting the circle.angle property with the calculated radian angle, the code should add a new property to keep the original angle property unaffected.

Not sure how it should be minified, so I'll leave that to you or someone else.

The code that triggered the bug for me:

  cssWarp({
    path: {
      radius: 60,
      angle: '180deg'
    },
    targets: '.someclass'
  });

The first target used the correct angle of 180deg, but following targets reverted to angle of 0 (or close to it), because the angle was rewritten in radians and then re-interpreted as degrees.

…hen applying warp to multiple elements.

Instead of overwriting the circle.angle property with the calculated radian angle, the code should add a new property to keep the original angle property unaffected.
Not sure how it should be minified, so I'll leave that to someone else.
dirkweber added a commit that referenced this pull request Feb 10, 2013
Fixed a bug where circle angle property resets to 0 after first element when applying warp to multiple elements
@dirkweber dirkweber merged commit 763d962 into dirkweber:master Feb 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants