- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
Specify CSS icon #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Specify CSS icon #39
Conversation
| Hi @itafraze, Thanks a lot for you interest in the package and for submitting this PR and sorry for the late in the reply. The reason why there is no icon still is that I wanted first to add a tooltip with some information on how to use the BondTable but due to time I never effectively implemented this. I would like to add an icon only after we have at least a very basic tooltip/description about this. If you are willing to also add a very small description about the BondTable (I can help you with understanding features) I think we can merge with an icon as well :) | 
| Hi @disberd, sure, I can look into it. But I'm not sure what you mean by 'tooltip/description'. | 
| Thanks for this. For an example you can look at the popout element in the bond table which has the actual div with the bonds appear only when hovering over the icon: PlutoExtras.jl/src/structbond/main_definitions.jl Lines 334 to 381 in 1582b78 
 Though this is of course not the only way to implement something similar (nor probably the best way to do it but I am not a javascript developer :P) | 
closes #38