feat(android): Add missing initialization of DisplayMetricsHolder
#107
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
https://app.asana.com/1/236888843494340/project/1211566197378916/task/1210654707296995
React Native has a parameter called
PixelRatio
(https://reactnative.dev/docs/pixelratio) which is responsible for scaling components and font size.DisplayMetricsHolder.kt
is responsible for storing values such asdensity
,fontScale
,width
, andheight
.While debugging why the Discord app scales font size and component sizes incorrectly, I noticed that
PixelRatio
values change incorrectly when changing the OS display size on Android:Screen.Recording.2025-10-08.at.16.45.26.mov
This PR adds the missing
DisplayMetricsHolder
initialization on Android:Screen.Recording.2025-10-08.at.16.49.40.mov
Test Plan:
Discord app :
Before :
Screen.Recording.2025-10-08.at.16.55.56.mov
After:
Screen.Recording.2025-10-08.at.16.59.39.mov
Changelog: