Chore/upgrade performance module to latest apis

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

@@ -9715,5 +9715,206 @@ declare module.exports: {
   get RootTagContext(): RootTagContext,
   get unstable_enableLogBox(): () => void,
 };
+declare export class PerformanceEventTiming extends PerformanceEntry {
+  constructor(init: {
+    name: string,
+    startTime?: DOMHighResTimeStamp,
+    duration?: DOMHighResTimeStamp,
+    processingStart?: DOMHighResTimeStamp,
+    processingEnd?: DOMHighResTimeStamp,
+    interactionId?: number,
+  }): void;
+  get processingStart(): DOMHighResTimeStamp;
+  get processingEnd(): DOMHighResTimeStamp;
+  get interactionId(): number;
+  toJSON(): PerformanceEventTimingJSON;
+}
+type EventCountsForEachCallbackType =
+  | (() => void)
+  | ((value: number) => void)
+  | ((value: number, key: string) => void)
+  | ((value: number, key: string, map: Map<string, number>) => void);
+declare export class EventCounts {
+  get size(): number;
+  entries(): Iterator<[string, number]>;
+  forEach(callback: EventCountsForEachCallbackType): void;
+  get(key: string): ?number;
+  has(key: string): boolean;
+  keys(): Iterator<string>;
+  values(): Iterator<number>;
+}
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/LongTasks.js 1`] = `
+"export type PerformanceLongTaskTimingJSON = {
+  ...PerformanceEntryJSON,
+  attribution: $ReadOnlyArray<TaskAttributionTiming>,
+  ...
+};
+declare export class TaskAttributionTiming extends PerformanceEntry {}
+declare export class PerformanceLongTaskTiming extends PerformanceEntry {
+  get attribution(): $ReadOnlyArray<TaskAttributionTiming>;
+  toJSON(): PerformanceLongTaskTimingJSON;
+}
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/MemoryInfo.js 1`] = `
+"type MemoryInfoLike = {
+  jsHeapSizeLimit: ?number,
+  totalJSHeapSize: ?number,
+  usedJSHeapSize: ?number,
+};
+declare export default class MemoryInfo {
+  constructor(memoryInfo: ?MemoryInfoLike): void;
+  get jsHeapSizeLimit(): ?number;
+  get totalJSHeapSize(): ?number;
+  get usedJSHeapSize(): ?number;
+}
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/Performance.js 1`] = `
+"export type PerformanceMeasureOptions = {
+  detail?: DetailType,
+  start?: DOMHighResTimeStamp,
+  duration?: DOMHighResTimeStamp,
+  end?: DOMHighResTimeStamp,
+};
+declare export default class Performance {
+  eventCounts: EventCounts;
+  get memory(): MemoryInfo;
+  get rnStartupTiming(): ReactNativeStartupTiming;
+  mark(markName: string, markOptions?: PerformanceMarkOptions): PerformanceMark;
+  clearMarks(markName?: string): void;
+  measure(
+    measureName: string,
+    startMarkOrOptions?: string | PerformanceMeasureOptions,
+    endMark?: string
+  ): PerformanceMeasure;
+  clearMeasures(measureName?: string): void;
+  now: () => DOMHighResTimeStamp;
+  getEntries(): PerformanceEntryList;
+  getEntriesByType(entryType: PerformanceEntryType): PerformanceEntryList;
+  getEntriesByName(
+    entryName: string,
+    entryType?: PerformanceEntryType
+  ): PerformanceEntryList;
+}
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/PerformanceEntry.js 1`] = `
+"export type DOMHighResTimeStamp = number;
+export type PerformanceEntryType =
+  | \\"mark\\"
+  | \\"measure\\"
+  | \\"event\\"
+  | \\"longtask\\"
+  | \\"resource\\";
+export type PerformanceEntryJSON = {
+  name: string,
+  entryType: PerformanceEntryType,
+  startTime: DOMHighResTimeStamp,
+  duration: DOMHighResTimeStamp,
+  ...
+};
+declare export class PerformanceEntry {
+  constructor(init: {
+    name: string,
+    entryType: PerformanceEntryType,
+    startTime: DOMHighResTimeStamp,
+    duration: DOMHighResTimeStamp,
+  }): void;
+  get name(): string;
+  get entryType(): PerformanceEntryType;
+  get startTime(): DOMHighResTimeStamp;
+  get duration(): DOMHighResTimeStamp;
+  toJSON(): PerformanceEntryJSON;
+}
+export type PerformanceEntryList = $ReadOnlyArray<PerformanceEntry>;
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/PerformanceObserver.js 1`] = `
+"export { PerformanceEntry } from \\"./PerformanceEntry\\";
+declare export class PerformanceObserverEntryList {
+  constructor(entries: PerformanceEntryList): void;
+  getEntries(): PerformanceEntryList;
+  getEntriesByType(type: PerformanceEntryType): PerformanceEntryList;
+  getEntriesByName(
+    name: string,
+    type?: PerformanceEntryType
+  ): PerformanceEntryList;
+}
+export type PerformanceObserverCallbackOptions = {
+  droppedEntriesCount: number,
+};
+export type PerformanceObserverCallback = (
+  list: PerformanceObserverEntryList,
+  observer: PerformanceObserver,
+  options?: PerformanceObserverCallbackOptions
+) => void;
+export interface PerformanceObserverInit {
+  +entryTypes?: Array<PerformanceEntryType>;
+  +type?: PerformanceEntryType;
+  +buffered?: boolean;
+  +durationThreshold?: DOMHighResTimeStamp;
+}
+declare export class PerformanceObserver {
+  constructor(callback: PerformanceObserverCallback): void;
+  observe(options: PerformanceObserverInit): void;
+  disconnect(): void;
+  static supportedEntryTypes: $ReadOnlyArray<PerformanceEntryType>;
+}
+export { PerformanceEventTiming };
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/ReactNativeStartupTiming.js 1`] = `
+"type ReactNativeStartupTimingLike = {
+  startTime: ?number,
+  endTime: ?number,
+  initializeRuntimeStart: ?number,
+  initializeRuntimeEnd: ?number,
+  executeJavaScriptBundleEntryPointStart: ?number,
+  executeJavaScriptBundleEntryPointEnd: ?number,
+};
+declare export default class ReactNativeStartupTiming {
+  constructor(startUpTiming: ?ReactNativeStartupTimingLike): void;
+  get startTime(): ?number;
+  get endTime(): ?number;
+  get initializeRuntimeStart(): ?number;
+  get initializeRuntimeEnd(): ?number;
+  get executeJavaScriptBundleEntryPointStart(): ?number;
+  get executeJavaScriptBundleEntryPointEnd(): ?number;
+}
+"
+`;
+
+exports[`public API should not change unintentionally src/private/webapis/performance/UserTiming.js 1`] = `
+"export type DetailType = mixed;
+export type PerformanceMarkOptions = {
+  detail?: DetailType,
+  startTime?: DOMHighResTimeStamp,
+};
+export type TimeStampOrName = DOMHighResTimeStamp | string;
+export type PerformanceMeasureInit = {
+  detail?: DetailType,
+  startTime: DOMHighResTimeStamp,
+  duration: DOMHighResTimeStamp,
+};
+declare export class PerformanceMark extends PerformanceEntry {
+  constructor(markName: string, markOptions?: PerformanceMarkOptions): void;
+  get detail(): DetailType;
+}
+declare export class PerformanceMeasure extends PerformanceEntry {
+  constructor(
+    measureName: string,
+    measureOptions: PerformanceMeasureInit
+  ): void;
+  get detail(): DetailType;
+}
 "
 `;

packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake

@@ -22,6 +22,7 @@ include(${CMAKE_CURRENT_LIST_DIR}/folly-flags.cmake)
 # We configured the REACT_COMMON_DIR variable as it's commonly used to reference
 # shared C++ code in other targets.
 set(REACT_COMMON_DIR ${REACT_ANDROID_DIR}/../ReactCommon)
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
 
 # If you have ccache installed, we're going to honor it.
 find_program(CCACHE_FOUND ccache)
@@ -60,21 +61,7 @@ target_include_directories(${CMAKE_PROJECT_NAME}
                 ${CMAKE_CURRENT_SOURCE_DIR}
                 ${PROJECT_BUILD_DIR}/generated/autolinking/src/main/jni)
 
-target_compile_options(${CMAKE_PROJECT_NAME}
-        PRIVATE
-                -Wall
-                -Werror
-                # We suppress cpp #error and #warning to don't fail the build
-                # due to use migrating away from
-                # #include <react/renderer/graphics/conversions.h>
-                # This can be removed for React Native 0.73
-                -Wno-error=cpp
-                -fexceptions
-                -frtti
-                -std=c++20
-                -DLOG_TAG=\"ReactNative\"
-                -DFOLLY_NO_CONFIG=1
-)
+target_compile_reactnative_options(${CMAKE_PROJECT_NAME} PRIVATE)
 
 # Prefab packages from React Native
 find_package(ReactAndroid REQUIRED CONFIG)

packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt

@@ -8,6 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on)
 
 project(ReactAndroid)
 
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
+
 # Convert input paths to CMake format (with forward slashes)
 file(TO_CMAKE_PATH "${REACT_ANDROID_DIR}" REACT_ANDROID_DIR)
 file(TO_CMAKE_PATH "${REACT_BUILD_DIR}" REACT_BUILD_DIR)
@@ -22,7 +24,6 @@ endif(CCACHE_FOUND)
 
 # Make sure every shared lib includes a .note.gnu.build-id header
 add_link_options(-Wl,--build-id)
-add_compile_options(-Wall -Werror)
 
 function(add_react_android_subdir relative_path)
   add_subdirectory(${REACT_ANDROID_DIR}/${relative_path} ReactAndroid/${relative_path})
@@ -237,6 +238,8 @@ target_link_libraries(reactnative
             yogacore
 )
 
+target_compile_reactnative_options(reactnative PRIVATE)
+
 target_include_directories(reactnative
         PUBLIC
         $<TARGET_PROPERTY:bridgeless,INTERFACE_INCLUDE_DIRECTORIES>
@@ -355,14 +358,9 @@ add_executable(reactnative_unittest
   # ${REACT_COMMON_DIR}/react/renderer/core/tests/ConcreteShadowNodeTest.cpp
   # ${REACT_COMMON_DIR}/react/renderer/core/tests/ComponentDescriptorTest.cpp
   )
-  target_compile_options(reactnative_unittest
-    PRIVATE
-    -Wall
-    -Werror
-    -fexceptions
-    -frtti
-    -std=c++20
-    -DHERMES_ENABLE_DEBUGGER)
+
+target_compile_reactnative_options(reactnative_unittest PRIVATE)
+target_compile_options(reactnative_unittest PRIVATE -DHERMES_ENABLE_DEBUGGER)
 
 target_link_libraries(reactnative_unittest
   fabricjni

packages/react-native/ReactAndroid/src/main/jni/first-party/fbgloginit/CMakeLists.txt

@@ -8,6 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on)
 
 add_compile_options(-fexceptions -fno-omit-frame-pointer)
 
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
+
 add_library(glog_init OBJECT glog_init.cpp)
 
 target_include_directories(glog_init PUBLIC .)

packages/react-native/ReactAndroid/src/main/jni/first-party/jni-lib-merge/CMakeLists.txt

@@ -6,6 +6,8 @@
 cmake_minimum_required(VERSION 3.13)
 set(CMAKE_VERBOSE_MAKEFILE on)
 
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
+
 # This is the 'glue' library responsible of allowing to do so-merging in React Native
 # OSS. This library contains just a .c file that is included in every merged library.
 #

packages/react-native/ReactAndroid/src/main/jni/first-party/yogajni/CMakeLists.txt

@@ -7,13 +7,7 @@ cmake_minimum_required(VERSION 3.13)
 set(CMAKE_VERBOSE_MAKEFILE on)
 
 include(${REACT_ANDROID_DIR}/src/main/jni/first-party/jni-lib-merge/SoMerging-utils.cmake)
-
-add_compile_options(
-        -fvisibility=hidden
-        -fexceptions
-        -frtti
-        -std=c++20
-        -O3)
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
 
 file(GLOB yoga_SRC CONFIGURE_DEPENDS jni/*.cpp)
 add_library(yoga OBJECT ${yoga_SRC})
@@ -27,3 +21,6 @@ target_link_libraries(yoga
         log
         android
 )
+
+target_compile_reactnative_options(yoga PRIVATE)
+target_compile_options(yoga PRIVATE -fvisibility=hidden -O3)

packages/react-native/ReactAndroid/src/main/jni/react/devsupport/CMakeLists.txt

@@ -6,9 +6,8 @@
 cmake_minimum_required(VERSION 3.13)
 set(CMAKE_VERBOSE_MAKEFILE on)
 
-add_compile_options(-fexceptions -frtti -std=c++20 -Wall -DLOG_TAG=\"ReactNative\")
-
 include(${REACT_ANDROID_DIR}/src/main/jni/first-party/jni-lib-merge/SoMerging-utils.cmake)
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
 
 file(GLOB react_devsupportjni_SRC CONFIGURE_DEPENDS *.cpp)
 
@@ -21,3 +20,5 @@ target_include_directories(react_devsupportjni PUBLIC .)
 target_link_libraries(react_devsupportjni
         fbjni
         jsinspector)
+
+target_compile_reactnative_options(react_devsupportjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt

@@ -6,6 +6,7 @@
 cmake_minimum_required(VERSION 3.13)
 
 include(${REACT_ANDROID_DIR}/src/main/jni/first-party/jni-lib-merge/SoMerging-utils.cmake)
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
 
 file(GLOB fabricjni_SRCS CONFIGURE_DEPENDS *.cpp)
 
@@ -62,12 +63,4 @@ target_link_libraries(
         yoga
 )
 
-target_compile_options(
-        fabricjni
-        PRIVATE
-        -DLOG_TAG=\"Fabric\"
-        -fexceptions
-        -frtti
-        -std=c++20
-        -Wall
-)
+target_compile_reactnative_options(fabricjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/CMakeLists.txt

@@ -6,6 +6,7 @@
 cmake_minimum_required(VERSION 3.13)
 
 include(${REACT_ANDROID_DIR}/src/main/jni/first-party/jni-lib-merge/SoMerging-utils.cmake)
+include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
 
 file(GLOB react_featureflagsjni_SRCS CONFIGURE_DEPENDS *.cpp)
 
@@ -25,13 +26,4 @@ target_link_libraries(
 )
 
 target_merge_so(react_featureflagsjni)
-
-target_compile_options(
-        react_featureflagsjni
-        PRIVATE
-        -DLOG_TAG=\"ReactNative\"
-        -fexceptions
-        -frtti
-        -std=c++20
-        -Wall
-)
+target_compile_reactnative_options(react_featureflagsjni PRIVATE)