Remove remainders of py2 support #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
remove-remainders-of-py2-support
branch
3 times, most recently
from
70403a1 to
8d393d2
Compare
In Python 2.x u'...' (unicode string) meant the same as '...' in Python 3. In Python 2.x '...' ([byte] string) meant the same as b'...' in Python 3. We do not support Python 2.x, so the u prefix is not useful anymore.
We use items(), keys(), values() and they all return iterators.
Coercion unicode<->str was a Python2 thing. Python3 always requires explicit conversion now, which is clearer and way less problematic.
was only needed for py2/py3 compatibility.
not used anymore.
ThomasWaldmann
force-pushed
the
remove-remainders-of-py2-support
branch
from
8d393d2 to
f8cacfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.