Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

A11Y: improve expand/collapse labeling on embedded solution post #381

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

awesomerobot
Copy link
Member

This adds an aria-label based on the state of the button and also moves the title to the button rather than the icon.

image image

I also noticed that aria-expanded was rendering as aria-expanded="" which isn't helpful, we need a true/false string as the examples show here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-expanded

@awesomerobot awesomerobot merged commit 0f03ec4 into main Jul 10, 2025
6 checks passed
@awesomerobot awesomerobot deleted the a11y-expand-collapse branch July 10, 2025 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants