This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Use the PostQuotedContent component to render the accepted answer #387
+294
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `solved-accepted-answer` component to utilize the `PostQuotedContent` component, simplifying the structure and removing redundant code. Updated system tests to verify behavior of expandable accepted answer quotes. Added new compatibility entry for version `< 3.5.0.beta7-dev` and included TODO comments regarding event handling for Glimmer Post Stream.
…er logic Refactored the `topic` model to replace legacy Ember property access (`get/set`) with modern tracked properties. Updated related logic in `add-topic-list-class` and `solved-unaccept-answer-button` to align with these changes.
Refactored `solved_spec.rb` to make `accepted answer` assertions more explicit and structured. Consolidated selector handling and clarified expectation of the expanded quote behavior.
Introduce real-time message bus updates for accepted and unaccepted solutions, ensuring live synchronization across users. Key changes: - Publish solution acceptance/unacceptance updates via MessageBus. - Refactor `accepted_answer_post_info` and related logic for cleaner handling of accepted answer data. - Update both backend and frontend to support reactive updates when solutions are toggled. - Add loading states for Accept/Unaccept buttons to enhance UX during async operations.
…tency This ensures tests work with topics that include an original post by default, improving test reliability and coverage. Adjustments were made to guardian_extensions_spec and solved_spec to reflect this.
…eta8-dev` Updated `.discourse-compatibility` to reflect compatibility with core version `< 3.5.0.beta8-dev`.
- Hide blockquote for accepted answers without excerpts to avoid unnecessary visual elements. - Adjust title padding for better alignment when excerpts are absent. - Ensure no content fallback (`""`) when excerpts are not provided. - Add `accepted-answer--has-excerpt` class for proper styling differentiation.
- Add a newline for better code readability and spacing consistency within the `solutions.scss` file. - No functional changes made.
| DiscourseEvent.trigger(:accepted_solution, post) | ||
| MessageBus.publish("/topic/#{topic.id}", message) |
There was a problem hiding this comment.
We need to add some security to this message, so that it only goes out to users/groups that have access to the topic
There was a problem hiding this comment.
There's a helper here: https://github.com/discourse/discourse/blob/5ba28911cafce491e7a0ce5fda10ea9046ddf1f7/app/models/topic.rb#L2081C27-L2081C27
And example use here: https://github.com/discourse/discourse/blob/5ba28911cafce491e7a0ce5fda10ea9046ddf1f7/plugins/discourse-reactions/app/controllers/discourse_reactions/custom_reactions_controller.rb#L290C5-L294C75
jjaffeux
reviewed
Jul 22, 2025
Comment on lines
+59
to
+61
| expect(topic_page).not_to have_css(".accepted-answer.quote") | ||
| expect(topic_page).not_to have_css(".title .accepted-answer--solver") | ||
| expect(topic_page).not_to have_css(".title .accepted-answer--accepter") |
There was a problem hiding this comment.
Most likely you wanted this here:
Suggested change
| expect(topic_page).not_to have_css(".accepted-answer.quote") | |
| expect(topic_page).not_to have_css(".title .accepted-answer--solver") | |
| expect(topic_page).not_to have_css(".title .accepted-answer--accepter") | |
| expect(topic_page).to have_no_css(".accepted-answer.quote") | |
| expect(topic_page).to have_no_css(".title .accepted-answer--solver") | |
| expect(topic_page).to have_no_css(".title .accepted-answer--accepter") |
jjaffeux
reviewed
Jul 22, 2025
| find(".post-action-menu__solved-unaccepted").click | ||
|
|
||
| expect(topic_page).to have_css(".post-action-menu__solved-accepted") | ||
|
|
||
| accepted_answer_quote = topic_page.find("aside.accepted-answer.quote") | ||
| expect(accepted_answer_quote["data-expanded"]).to eq("false") |
There was a problem hiding this comment.
that's not a correct way to do, it's not using auto-wait, should be:
Suggested change
| expect(accepted_answer_quote["data-expanded"]).to eq("false") | |
| expect(topic_page).to have_css("aside.accepted-answer.quote[data-expanded='false']") |
Haven't tested locally, but you get the idea...
jjaffeux
reviewed
Jul 22, 2025
Comment on lines
+41
to
+42
| accepted_answer_quote.find("button.quote-toggle").click | ||
| expect(accepted_answer_quote["data-expanded"]).to eq("true") |
There was a problem hiding this comment.
same thing, it's not auto-waiting, see above for solution
jjaffeux
reviewed
Jul 22, 2025
Comment on lines
+45
to
+49
| try { | ||
| await unacceptPost(post); | ||
| } finally { | ||
| this.saving = false; | ||
| } |
There was a problem hiding this comment.
should we surface an error when it fails?
jjaffeux
approved these changes
Jul 22, 2025
jjaffeux
suggested changes
Jul 22, 2025
|
Moving plugin to core, so we'll need to re-open this in discourse/discourse. Sorry @megothss |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the accepted answer functionality in the discourse-solved plugin with several key improvements:
Core Changes
solved-accepted-answercomponent with thePostQuotedContentcore component for better consistency and maintainabilityget/setpatterns to tracked properties for better reactivityTechnical Improvements
accepted_answer_post_infologic for cleaner data handlingtopic_with_opfabricationCompatibility
< 3.5.0.beta8-devThe changes ensure that solution state updates are reflected immediately across all connected users while providing a more robust and maintainable foundation for the plugin.