Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ytdlp] Fixes an issue with incorrect warning message. #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hoshimikan6490
Copy link

What's PR for?

fix the small issue for @distube/ytdlp package.

PR details

When using the @distube/ytdlp package, the message "[YtDlpPlugin] This plugin is not the last plugin in distube. This is not recommended." is displayed on the console. The problem is that the version check process compares the local YtDlpPlugin version with the remote (released) DeezerPlugin version. Therefore, fixing the process to correctly compare the local and remote YtDlpPlugin versions would fix this problem.

PR priority

LOW

@skick1234
Copy link
Contributor

What is your plugins option array?

@Hoshimikan6490
Copy link
Author

My plugins option array is this.

plugins: [
  new YouTubePlugin(),
  new SpotifyPlugin(),
  new SoundCloudPlugin(),
  new YtDlpPlugin(),
  new DeezerPlugin(),
]

I don't know if there might be an issue with the order of the plugins options array. If so, it's possible that I might have made an incorrect PR. If that is the case, I sincerely apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants