refactor: change subflake locking to an absolute git locking strategy for compatibility with nix 2.18+ #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: blaggacao <[email protected]>
…er-action@main for Nix 2.18+ compatibility Co-authored-by: blaggacao <[email protected]>
…ion@v32 Co-authored-by: blaggacao <[email protected]>
blaggacao
force-pushed
the
refactor/self-referential-locking-on-the-fly
branch
3 times, most recently
from
b2f8e36 to
595b22a
Compare
… for compatibility with nix 2.18+
blaggacao
force-pushed
the
refactor/self-referential-locking-on-the-fly
branch
from
595b22a to
19fc813
Compare
blaggacao
force-pushed
the
refactor/self-referential-locking-on-the-fly
branch
from
19fc813 to
4867218
Compare
|
I think this merits a fuller discussion(I understand both sides) of if we should more fully switch to flake-parts. It seems that they already have a flakePartitions module similar to what this does, except it works with newer nix for reasons I do not know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416 - alternative to #417.
Fixes #411.